-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shader crash when the comma used in for
loop as a trailing
#95350
Fix shader crash when the comma used in for
loop as a trailing
#95350
Conversation
7407577
to
d74749f
Compare
Thanks @Chaosus . Is this only for dealing with trailing commas (to show text editor error instead of crash)?
|
Yes
This is not a valid because only boolean expressions are allowed on middle place. That is allowed expression in GLSL, though. |
Exactly. It's valid GLSL because only the last comma part needs to be a boolean (if you allow commas here like in GLSL). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
Cherry-picked for 4.3.1. |
Prevents shader compiler crash (not an actual crash) when using incorrect trailing commas in for loop expression: